[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 3/4] target-i386: Register QOM properties for
From: |
Igor Mammedov |
Subject: |
Re: [Qemu-devel] [PATCH v2 3/4] target-i386: Register QOM properties for feature flags |
Date: |
Fri, 10 Apr 2015 09:27:51 +0200 |
On Thu, 9 Apr 2015 15:48:30 -0300
Eduardo Habkost <address@hidden> wrote:
> On Wed, Apr 08, 2015 at 04:02:42PM -0300, Eduardo Habkost wrote:
> [...]
> > + names = g_strsplit(fi->feat_names[bit], "|", 0);
>
> I forgot to implement the property aliases Igor asked for. I will
> submit v3 of this patch later.
>
> > + for (i = 0; names[i]; i++) {
> > + char *feat_name = names[i];
> > + feat2prop(feat_name);
> > + char *prop_name = g_strdup_printf("cpuid-%s", feat_name);
BTW: I've remembered why we've chosen feat- vs. cpuid- prefix
it was to make CPU features platform neutral so that libvirt
would use the same prefix for x86, arm other targets.
> > + x86_cpu_register_feature_prop(cpu, prop_name, w, (1UL <<
> > bit));
> > + g_free(prop_name);
> > + }
> > + g_strfreev(names);
> > +}
> > +
[Qemu-devel] [PATCH v2 4/4] scripts: x86-cpu-model-dump script, Eduardo Habkost, 2015/04/08