qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v4 06/20] hw/arm/virt-acpi-build: Generation of


From: Igor Mammedov
Subject: Re: [Qemu-devel] [PATCH v4 06/20] hw/arm/virt-acpi-build: Generation of DSDT table for virt devices
Date: Fri, 10 Apr 2015 09:35:16 +0200

On Fri, 10 Apr 2015 13:59:25 +0800
Shannon Zhao <address@hidden> wrote:

> On 2015/4/9 21:03, Igor Mammedov wrote:
> > On Thu, 09 Apr 2015 10:51:33 +0100
> > Alex Bennée <address@hidden> wrote:
> > 
> >> > 
> >> > Shannon Zhao <address@hidden> writes:
> >> > 
> >>> > > From: Shannon Zhao <address@hidden>
> >>> > >
> >>> > > DSDT consists of the usual common table header plus a
> >>> > > definition block in AML encoding which describes all devices
> >>> > > in the platform.
> >>> > >
> >>> > > After initializing DSDT with header information the namespace
> >>> > > is created which is followed by the device encodings. The
> >>> > > devices are described using the Resource Template for the
> >>> > > 32-Bit Fixed Memory Range and the Extended Interrupt
> >>> > > Descriptors.
> >>> > >
> >>> > > Signed-off-by: Shannon Zhao <address@hidden>
> >>> > > Signed-off-by: Shannon Zhao <address@hidden>
> >>> > > ---
> >>> > >  hw/arm/virt-acpi-build.c | 137
> >>> > > +++++++++++++++++++++++++++++++++++++++++++++++ 1 file
> >>> > > changed, 137 insertions(+)
> >>> > >
> >>> > > diff --git a/hw/arm/virt-acpi-build.c
> >>> > > b/hw/arm/virt-acpi-build.c index 388838a..516c1d0 100644
> >>> > > --- a/hw/arm/virt-acpi-build.c
> >>> > > +++ b/hw/arm/virt-acpi-build.c
> >>> > > @@ -57,6 +57,139 @@
> >>> > >  #define ACPI_BUILD_DPRINTF(fmt, ...)
> > I wonder if all this DPRINTF crap should be replaced by tracepoints.
> > Oo at least it shouldn't be used in new code.
> > 
> 
> Anything wrong with using DPRINTF?
tracepoints could be enabled without rebuilding qemu




reply via email to

[Prev in Thread] Current Thread [Next in Thread]