[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 3/4] target-i386: Register QOM properties for
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH v2 3/4] target-i386: Register QOM properties for feature flags |
Date: |
Fri, 10 Apr 2015 10:53:43 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 |
Am 10.04.2015 um 10:21 schrieb Paolo Bonzini:
> On 10/04/2015 09:27, Igor Mammedov wrote:
>>> + for (i = 0; names[i]; i++) {
>>> + char *feat_name = names[i];
>>> + feat2prop(feat_name);
>>> + char *prop_name = g_strdup_printf("cpuid-%s", feat_name);
>>
>> BTW: I've remembered why we've chosen feat- vs. cpuid- prefix
>> it was to make CPU features platform neutral so that libvirt
>> would use the same prefix for x86, arm other targets.
>
> Ok, that make sense, but if we want to make it platform-neutral, let's
> spell it "feature-" or remove the prefix altogether.
>
> If we remove it, perhaps we could add a QOM property with the list of
> features?
>
> But I don't want to bikeshed too much.
I had suggested a container sub-object for property grouping but Anthony
preferred a prefix.
Btw a suffix could work as well and would read more natural. QMP don't
sort alphabetically anyway.
Andreas
--
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu,
Graham Norton; HRB 21284 (AG Nürnberg)
[Qemu-devel] [PATCH v2 4/4] scripts: x86-cpu-model-dump script, Eduardo Habkost, 2015/04/08