qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 3/4] target-i386: Register QOM properties for


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH v2 3/4] target-i386: Register QOM properties for feature flags
Date: Fri, 10 Apr 2015 10:59:18 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0


On 10/04/2015 10:53, Andreas Färber wrote:
> > Ok, that make sense, but if we want to make it platform-neutral, let's
> > spell it "feature-" or remove the prefix altogether.
> > 
> > If we remove it, perhaps we could add a QOM property with the list of
> > features?
> > 
> > But I don't want to bikeshed too much.
> 
> I had suggested a container sub-object for property grouping but Anthony
> preferred a prefix.

And I agree. :)  However, it seems to me that properties such as
feature-words and filtered-features are a good precedent so we might as
well add all-features.

> Btw a suffix could work as well and would read more natural. QMP don't
> sort alphabetically anyway.

QMP doesn't, but the front-end (scripts/qom-list for example) could.

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]