Re: [Qemu-devel] [PATCH for-2.3] stm32f205: Fix SoC type name

[Alistair Francis]

On Sat, Apr 11, 2015 at 12:37 AM, Andreas Färber <address@hidden> wrote:
> The type name for the SoC device, unlike those of its sub-devices,
> did not follow the QOM naming conventions. While the usage is internal
> only, this is exposed through QMP and HMP, so fix it before release.
>
> Cc: Alistair Francis <address@hidden>
> Signed-off-by: Andreas Färber <address@hidden>

Looks good to me. Sorry about this slipping in, thanks for fixing it.

Reviewed-by: Alistair Francis <address@hidden>

Thanks,

Alistair

> ---
>  include/hw/arm/stm32f205_soc.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/hw/arm/stm32f205_soc.h b/include/hw/arm/stm32f205_soc.h
> index 3cda170..0390eff 100644
> --- a/include/hw/arm/stm32f205_soc.h
> +++ b/include/hw/arm/stm32f205_soc.h
> @@ -29,7 +29,7 @@
>  #include "hw/timer/stm32f2xx_timer.h"
>  #include "hw/char/stm32f2xx_usart.h"
>
> -#define TYPE_STM32F205_SOC "stm32f205_soc"
> +#define TYPE_STM32F205_SOC "stm32f205-soc"
>  #define STM32F205_SOC(obj) \
>      OBJECT_CHECK(STM32F205State, (obj), TYPE_STM32F205_SOC)
>
> --
> 2.1.4
>
>