Re: [Qemu-devel] [PATCH 03/12 v9] linux-user: Support tilegx architecture in syscall

[Chen Gang]

On 4/10/15 05:38, Peter Maydell wrote:
> On 27 March 2015 at 10:50, Chen Gang <address@hidden> wrote:

[...]

>>
>> +#elif defined(TARGET_TILEGX)
>> +
>> +/* Copy from Linux kernel "uapi/asm-generic/stat.h" */
>> +struct target_stat {
>> +        abi_ulong st_dev;               /* Device.  */
>> +        abi_ulong st_ino;               /* File serial number.  */
>> +        unsigned int st_mode;           /* File mode.  */
>> +        unsigned int st_nlink;          /* Link count.  */
>> +        unsigned int st_uid;            /* User ID of the file's owner.  */
>> +        unsigned int st_gid;            /* Group ID of the file's group. */
>> +        abi_ulong st_rdev;              /* Device number, if device.  */
>> +        abi_ulong __pad1;
>> +        abi_long  st_size;              /* Size of file, in bytes.  */
>> +        int st_blksize;                 /* Optimal block size for I/O.  */
>> +        int __pad2;
>> +        abi_long st_blocks;             /* Number 512-byte blocks 
>> allocated. */
>> +        abi_long target_st_atime;       /* Time of last access.  */
>> +        abi_ulong target_st_atime_nsec;
>> +        abi_long target_st_mtime;       /* Time of last modification.  */
>> +        abi_ulong target_st_mtime_nsec;
>> +        abi_long target_st_ctime;       /* Time of last status change.  */
>> +        abi_ulong target_st_ctime_nsec;
>> +        unsigned int __unused4;
>> +        unsigned int __unused5;
>> +};
> 
> We already have the generic stat struct for TARGET_OPENRISC,
> so you should just add TILEGX to the #if for that. (Pretty
> sure you want the stat64 struct too, or at least that it
> won't hurt.)
> 

OK, thanks, it sounds a good idea to me.

Thanks.
-- 
Chen Gang

Open, share, and attitude like air, water, and life which God blessed