[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-2.3? 7/7] tests/tcg: Enable runcom test by d
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH for-2.3? 7/7] tests/tcg: Enable runcom test by default |
Date: |
Sat, 11 Apr 2015 23:46:47 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 |
Am 11.04.2015 um 23:33 schrieb Peter Maydell:
> On 11 April 2015 at 21:28, Andreas Färber <address@hidden> wrote:
>> Are you sure that QEMU / runcom / pi_10.com still try to map to that
>> address zero?
>
> It's the first thing runcom.c's main() does after checking you've
> passed it enough command line arguments.
This?
vm86_mem = mmap((void *)0x00000000, 0x110000,
PROT_WRITE | PROT_READ | PROT_EXEC,
MAP_FIXED | MAP_ANON | MAP_PRIVATE, -1, 0);
if (vm86_mem == MAP_FAILED) {
perror("mmap");
exit(1);
}
For whatever reason it does not take the MAP_FAILED path here...
But I can certainly live with dropping this patch, it's the last for a
reason. :)
Andreas
--
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu,
Graham Norton; HRB 21284 (AG Nürnberg)
- Re: [Qemu-devel] [PATCH for-2.3? 4/7] tests/tcg: Fix running x86_64 tests, (continued)
- [Qemu-devel] [PATCH for-2.3? 2/7] tests/tcg: Fix linux-test build, Andreas Färber, 2015/04/11
- [Qemu-devel] [PATCH for-2.3? 3/7] tests/tcg: Disable hanging test-mmap runs, Andreas Färber, 2015/04/11
- [Qemu-devel] [PATCH for-2.3? 1/7] tests/tcg: Fix test_path build, Andreas Färber, 2015/04/11
- [Qemu-devel] [PATCH for-2.3? 7/7] tests/tcg: Enable runcom test by default, Andreas Färber, 2015/04/11
- Re: [Qemu-devel] [PATCH for-2.3? 7/7] tests/tcg: Enable runcom test by default, Peter Maydell, 2015/04/11
- Re: [Qemu-devel] [PATCH for-2.3? 7/7] tests/tcg: Enable runcom test by default, Andreas Färber, 2015/04/11
- Re: [Qemu-devel] [PATCH for-2.3? 7/7] tests/tcg: Enable runcom test by default, Peter Maydell, 2015/04/11
- Re: [Qemu-devel] [PATCH for-2.3? 7/7] tests/tcg: Enable runcom test by default,
Andreas Färber <=
- Re: [Qemu-devel] [PATCH for-2.3? 7/7] tests/tcg: Enable runcom test by default, Alexander Graf, 2015/04/12
- Re: [Qemu-devel] [PATCH for-2.3? 7/7] tests/tcg: Enable runcom test by default, Andreas Färber, 2015/04/12
- Re: [Qemu-devel] [PATCH for-2.3? 7/7] tests/tcg: Enable runcom test by default, Peter Maydell, 2015/04/12
[Qemu-devel] [PATCH for-2.3? 6/7] tests/tcg: Prettify run-runcom output, Andreas Färber, 2015/04/11
[Qemu-devel] [PATCH for-2.3? 5/7] tests/tcg: Fix run-runcom target, Andreas Färber, 2015/04/11
Re: [Qemu-devel] [PATCH for-2.3? 0/7] tests: Fix TCG make test, Peter Maydell, 2015/04/13