qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] Fix crash with illegal "-net nic, model=xxx" op


From: Peter Maydell
Subject: Re: [Qemu-devel] [PATCH] Fix crash with illegal "-net nic, model=xxx" option
Date: Mon, 13 Apr 2015 12:28:28 +0100

On 13 April 2015 at 04:01, Jason Wang <address@hidden> wrote:
>
>
> On Thu, Apr 9, 2015 at 9:32 PM, Thomas Huth <address@hidden> wrote:
>>
>> Current QEMU crashes when specifying an illegal model with the
>> "-net nic,model=xxx" option, e.g.:
>>
>>  $ qemu-system-x86_64 -net nic,model=n/a
>>  qemu-system-x86_64: Unsupported NIC model: n/a

>> The problem is that pci_nic_init_nofail() does not check whether the err
>> parameter from pci_nic_init has been set up and thus passes a NULL pointer
>> to error_report_err(). Fix it by correctly checking the err parameter.
>>
>> Signed-off-by: Thomas Huth <address@hidden>

> Reviewed-by: Jason Wang <address@hidden>

Applied, thanks (with a 'pci:' subject prefix added).

-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]