[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/2] target-i386: disable LINT0 after reset
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 1/2] target-i386: disable LINT0 after reset |
Date: |
Mon, 13 Apr 2015 16:12:45 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 |
On 13/04/2015 01:32, Nadav Amit wrote:
> Due to old Seabios bug, QEMU reenable LINT0 after reset. This bug is long gone
> and therefore this hack is no longer needed. Since it violates the
> specifications, it is removed.
>
> Signed-off-by: Nadav Amit <address@hidden>
> ---
> hw/intc/apic_common.c | 9 ---------
> 1 file changed, 9 deletions(-)
>
> diff --git a/hw/intc/apic_common.c b/hw/intc/apic_common.c
> index 042e960..d38d24b 100644
> --- a/hw/intc/apic_common.c
> +++ b/hw/intc/apic_common.c
> @@ -243,15 +243,6 @@ static void apic_reset_common(DeviceState *dev)
> info->vapic_base_update(s);
>
> apic_init_reset(dev);
> -
> - if (bsp) {
> - /*
> - * LINT0 delivery mode on CPU #0 is set to ExtInt at initialization
> - * time typically by BIOS, so PIC interrupt can be delivered to the
> - * processor when local APIC is enabled.
> - */
> - s->lvt[APIC_LVT_LINT0] = 0x700;
> - }
> }
>
> /* This function is only used for old state version 1 and 2 */
>
Thanks, applied this one. The other will have to wait for a bit, since
it depends on a patch that is destined to Linux 4.2.
Paolo