[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6 8/8] qmp-event: add event notification for me
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v6 8/8] qmp-event: add event notification for memory hot unplug error |
Date: |
Mon, 13 Apr 2015 08:40:04 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 |
On 04/12/2015 07:56 PM, Zhu Guihua wrote:
>
> On 04/10/2015 11:37 PM, Eric Blake wrote:
>> On 04/02/2015 03:50 AM, Zhu Guihua wrote:
>>> When memory hot unplug fails, this patch adds support to send
>>> QMP event to notify mgmt about this failure.
>>>
>>> Signed-off-by: Zhu Guihua <address@hidden>
>>> ---
>>> docs/qmp/qmp-events.txt | 17 +++++++++++++++++
>>> hw/acpi/memory_hotplug.c | 10 +++++++++-
>>> monitor.c | 1 +
>>> qapi/event.json | 14 ++++++++++++++
>>> trace-events | 1 +
>>> 5 files changed, 42 insertions(+), 1 deletion(-)
>>> +##
>>> +# @MEM_UNPLUG_ERROR
>>> +#
>>> +# Emitted when memory hot unplug error occurs.
>>> +#
>>> +# @device: device name
>>> +#
>>> +# @msg: Informative message
>> Any reason you abbreviated instead of spelling it out as 'message'?
>
> This only refer to the spelling of event BLOCK_IMAGE_CORRUPTED
> in docs/qmp/qmp-events.txt.
Just because existing code abbreviated does not mean that new code needs
to copy the bad example.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
- [Qemu-devel] [PATCH v6 0/8] QEMU memory hot unplug support, Zhu Guihua, 2015/04/02
- [Qemu-devel] [PATCH v6 2/8] acpi, mem-hotplug: add acpi_memory_slot_status() to get MemStatus, Zhu Guihua, 2015/04/02
- [Qemu-devel] [PATCH v6 3/8] acpi, mem-hotplug: add unplug request cb for memory device, Zhu Guihua, 2015/04/02
- [Qemu-devel] [PATCH v6 6/8] acpi: fix "Memory device control fields" register, Zhu Guihua, 2015/04/02
- [Qemu-devel] [PATCH v6 5/8] acpi: extend aml_field() to support UpdateRule, Zhu Guihua, 2015/04/02
- [Qemu-devel] [PATCH v6 4/8] acpi, mem-hotplug: add unplug cb for memory device, Zhu Guihua, 2015/04/02
- [Qemu-devel] [PATCH v6 8/8] qmp-event: add event notification for memory hot unplug error, Zhu Guihua, 2015/04/02
[Qemu-devel] [PATCH v6 7/8] acpi: add hardware implementation for memory hot unplug, Zhu Guihua, 2015/04/02
Re: [Qemu-devel] [PATCH v6 0/8] QEMU memory hot unplug support, Zhu Guihua, 2015/04/08
Re: [Qemu-devel] [PATCH v6 0/8] QEMU memory hot unplug support, Igor Mammedov, 2015/04/10