[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH RFC 09/19] qapi: qapi-commands.py option --type
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH RFC 09/19] qapi: qapi-commands.py option --type is unused, drop it |
Date: |
Mon, 13 Apr 2015 13:12:10 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 |
On 04/02/2015 11:28 AM, Markus Armbruster wrote:
> Anything but --type sync (which is the default) suppresses output
> entirely, which makes no sense.
>
> Dates back to the initial commit c17d990. Commit message says
> "Currently only generators for synchronous qapi/qmp functions are
> supported", so maybe output other than "synchronous qapi/qmp" was
> planned at the time, to be selected with --type.
>
> Should other kinds of output ever materialize, we can put the option
> back.
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> scripts/qapi-commands.py | 66
> +++++++++++++++++++++++-------------------------
> 1 file changed, 31 insertions(+), 35 deletions(-)
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH RFC 00/19] qapi: QMP introspection, Markus Armbruster, 2015/04/02
- [Qemu-devel] [PATCH RFC 06/19] qapi: Use c_enum_const() in generate_alternate_qtypes(), Markus Armbruster, 2015/04/02
- [Qemu-devel] [PATCH RFC 07/19] qapi: Move camel_to_upper(), c_enum_const() to closely related code, Markus Armbruster, 2015/04/02
- [Qemu-devel] [PATCH RFC 12/19] qapi: Turn generators' mandatory option -i into an argument, Markus Armbruster, 2015/04/02
- [Qemu-devel] [PATCH RFC 09/19] qapi: qapi-commands.py option --type is unused, drop it, Markus Armbruster, 2015/04/02
- Re: [Qemu-devel] [PATCH RFC 09/19] qapi: qapi-commands.py option --type is unused, drop it,
Eric Blake <=
- [Qemu-devel] [PATCH RFC 15/19] qapi: Inline gen_command_decl_prologue(), gen_command_def_prologue(), Markus Armbruster, 2015/04/02
- [Qemu-devel] [PATCH RFC 17/19] qobject: Add a special null QObject, Markus Armbruster, 2015/04/02
- [Qemu-devel] [PATCH RFC 14/19] qapi: Drop pointless flush() before close(), Markus Armbruster, 2015/04/02
- [Qemu-devel] [PATCH RFC 18/19] json-parser: Fix to recognize null, Markus Armbruster, 2015/04/02
- [Qemu-devel] [PATCH RFC 19/19] qapi: New QMP command query-schema for QMP schema introspection, Markus Armbruster, 2015/04/02