qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH RFC 09/19] qapi: qapi-commands.py option --type


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH RFC 09/19] qapi: qapi-commands.py option --type is unused, drop it
Date: Mon, 13 Apr 2015 13:12:10 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0

On 04/02/2015 11:28 AM, Markus Armbruster wrote:
> Anything but --type sync (which is the default) suppresses output
> entirely, which makes no sense.
> 
> Dates back to the initial commit c17d990.  Commit message says
> "Currently only generators for synchronous qapi/qmp functions are
> supported", so maybe output other than "synchronous qapi/qmp" was
> planned at the time, to be selected with --type.
> 
> Should other kinds of output ever materialize, we can put the option
> back.
> 
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
>  scripts/qapi-commands.py | 66 
> +++++++++++++++++++++++-------------------------
>  1 file changed, 31 insertions(+), 35 deletions(-)

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]