[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 1/4] qapi: Fix C identifiers generated for na

From: Alberto Garcia
Subject: Re: [Qemu-devel] [PATCH v2 1/4] qapi: Fix C identifiers generated for names containing '.'
Date: Wed, 15 Apr 2015 10:01:37 +0200
User-agent: Notmuch/0.13.2 (http://notmuchmail.org) Emacs/23.2.1 (i486-pc-linux-gnu)

On Sáb 11 Abr 2015 20:09:40 CEST, Eric Blake <address@hidden> wrote:
> From: Markus Armbruster <address@hidden>
> c_fun() maps '.' to '_', c_var() doesn't.  Nothing prevents '.' in
> QAPI names that get passed to c_var().
> Which QAPI names get passed to c_fun(), to c_var(), or to both is not
> obvious.  Names of command parameters and struct type members get
> passed to c_var().
> c_var() strips a leading '*', but this cannot happen.  c_fun()
> doesn't.
> Fix c_var() to work exactly like c_fun().
> Perhaps they should be replaced by a single mapping function.
> Signed-off-by: Markus Armbruster <address@hidden>
> [add 'import string']
> Signed-off-by: Eric Blake <address@hidden>

Reviewed-by: Alberto Garcia <address@hidden>


reply via email to

[Prev in Thread] Current Thread [Next in Thread]