[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [v7 12/14] migration: Use an array instead of 3 paramet
From: |
Li, Liang Z |
Subject: |
Re: [Qemu-devel] [v7 12/14] migration: Use an array instead of 3 parameters |
Date: |
Wed, 15 Apr 2015 08:35:54 +0000 |
> Eric Blake <address@hidden> wrote:
> > On 04/08/2015 12:20 AM, Liang Li wrote:
> >> Put the three parameters related to multiple thread (de)compression
> >> into an int array, and use an enum type to index the parameter.
> >>
> >> Signed-off-by: Liang Li <address@hidden>
> >> Signed-off-by: Yang Zhang <address@hidden>
> >> ---
> >> include/migration/migration.h | 4 +---
> >> migration/migration.c | 31 +++++++++++++++++++------------
> >> qapi-schema.json | 23 +++++++++++++++++++++++
> >> 3 files changed, 43 insertions(+), 15 deletions(-)
> >>
> >
> >> +++ b/qapi-schema.json
> >> @@ -569,6 +569,29 @@
> >> ##
> >> { 'command': 'query-migrate-capabilities', 'returns':
> ['MigrationCapabilityStatus']}
> >>
> >> +# @MigrationParameter
> >> +#
> >> +# Migration parameters enumeration
> >> +#
> >> +# @compress-level: Set the compression level to be used in live
> migration,
> >> +# the compression level is an integer between 0 and 9, where 0
> means
> >> +# no compression, 1 means the best compression speed, and 9
> means best
> >> +# compression ratio which will consume more CPU.
> >> +#
> >> +# @compress-threads: Set compression thread count to be used in live
> migration,
> >> +# the compression thread count is an integer between 1 and 255.
> >> +#
> >> +# @decompress-threads: Set decompression thread count to be used in
> live
> >> +# migration, the decompression thread count is an integer between
> 1
> >> +# and 255. Usually, decompression is at least 4 times as fast as
> >> +# compression, so set the decompress-threads to the number
> about 1/4
> >> +# of compress-threads is adequate.
> >
> > s/so set/so setting/
> >
> >> +#
> >> +# Since: 2.3
> >
> > 2.4
> >
> > Maintainer can fix if a respin is not needed.
>
> Liang, I will fix the s/2.3/2.4/ while merging, no need of respin for this.
>
> Later, Juan.
OK, the v8 is very soon.
Liang
- Re: [Qemu-devel] [v7 10/14] migration: Add the core code for decompression, (continued)
[Qemu-devel] [v7 11/14] migration: Add interface to control compression, Liang Li, 2015/04/08
[Qemu-devel] [v7 12/14] migration: Use an array instead of 3 parameters, Liang Li, 2015/04/08
[Qemu-devel] [v7 13/14] migration: Add qmp commands to set and query parameters, Liang Li, 2015/04/08
Re: [Qemu-devel] [v7 13/14] migration: Add qmp commands to set and query parameters, Eric Blake, 2015/04/14
[Qemu-devel] [v7 14/14] migration: Add hmp interface to set and query parameters, Liang Li, 2015/04/08