qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [V9fs-developer] [Bug 1336794] Re: 9pfs does not honor


From: Eric Van Hensbergen
Subject: Re: [Qemu-devel] [V9fs-developer] [Bug 1336794] Re: 9pfs does not honor open file handles on unlinked files
Date: Wed, 15 Apr 2015 14:17:41 +0000

good to know, thanks dominique.  I gave it a sniff test with FSX and a few other benchmarks, but I need to hit it with some multithreaded regressions.  Any pointers to reproducible failure cases would be beneficial.

On Wed, Apr 15, 2015 at 6:28 AM Dominique Martinet <address@hidden> wrote:
Eric Van Hensbergen wrote on Mon, Apr 13, 2015 at 04:05:28PM +0000:
> Well, technically fid 3 isn't 'open', only fid 2 is open - at least
> according to the protocol.  fid 3 and fid 2 are both clones of fid 1.

Right, they're clone fids, but nothing in the protocol says what should
happen to non-open fids when you unlink the file either - I guess both
behaviours are OK as long as the client can handle it, so it would make
sense to at least call fstat() on the fid matching the fd, but while
I think this is how the kernel currently behaves the kernel doesn't HAVE
to make one open, separate fid per open file descriptor either.

> However, thanks for the alternative workaround.  If you get a chance, can
> you check that my change to the client to partially fix this for the other
> servers doesn't break nfs-ganesha:
>
> https://github.com/ericvh/linux/commit/fddc7721d6d19e4e6be4905f37ade5b0521f4ed5

I'm afraid I haven't had much time lately, but while fstat-after-unlink
still works I'm getting some Oops with my basic test suite (create empty
files and rm -rf, kernel compilation, etc - nothing fancy) to the point
of locking myself out of my test box pretty quickly.

I'll try to debug patches a bit more individually (trying everything at
once isn't helping), but at the very least something is fishy

--
Dominique Martinet

reply via email to

[Prev in Thread] Current Thread [Next in Thread]