qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH for-2.4 05/10] block/iscsi: optimize WRITE10/16


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH for-2.4 05/10] block/iscsi: optimize WRITE10/16 if cache.writeback is not set
Date: Thu, 16 Apr 2015 15:17:06 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0


On 16/04/2015 15:02, Peter Lieven wrote:
>>>
>> Also, I think it is iscsi_co_generic_cb that should set
>> force_next_flush, so that it is only set on failure.  Not really for the
>> optimization value, but because it's clearer.
> 
> I don't get what you mean with it should only "set on failure".
> My approach would be to add a flag to the iTask that the command
> requires to set force_flush after successful completion. Is it that
> what you mean?

Set on success.  Lack of sleep.

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]