qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [[PATCH] 2/7] target-arm: Extend helpers to route excep


From: Peter Maydell
Subject: Re: [Qemu-devel] [[PATCH] 2/7] target-arm: Extend helpers to route exceptions
Date: Thu, 16 Apr 2015 18:51:06 +0100

On 27 March 2015 at 19:10, Greg Bellows <address@hidden> wrote:
> Updated the various helper routines to set the target EL as needed.
>
> Signed-off-by: Greg Bellows <address@hidden>
> ---
>  target-arm/op_helper.c | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/target-arm/op_helper.c b/target-arm/op_helper.c
> index 72a973a..aa175b5 100644
> --- a/target-arm/op_helper.c
> +++ b/target-arm/op_helper.c
> @@ -306,6 +306,7 @@ void HELPER(access_check_cp_reg)(CPUARMState *env, void 
> *rip, uint32_t syndrome)
>      if (arm_feature(env, ARM_FEATURE_XSCALE) && ri->cp < 14
>          && extract32(env->cp15.c15_cpar, ri->cp, 1) == 0) {
>          env->exception.syndrome = syndrome;
> +        env->exception.target_el = MAX(arm_current_el(env), 1);

Again, I don't think we should have all these MAX()es.

-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]