[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH RFC 1/3] memory: Add dump-pc-mem command for che
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH RFC 1/3] memory: Add dump-pc-mem command for checkpointing |
Date: |
Fri, 17 Apr 2015 07:53:54 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 |
On 04/17/2015 06:13 AM, Bohdan Trach wrote:
> From: Bohdan Trach <address@hidden>
>
> dump-pc-mem command is added for checkpointing guest memory to
> file. Only system RAM region is saved. This checkpoint is later used to
> recover unchanged pages.
>
> Signed-off-by: Bohdan Trach <address@hidden>
> ---
>
> +void qmp_dump_pc_ram(const char *file, Error **errp) {
> +
> + int rc;
> + int fd;
> + fd = open(file,
Please use qemu_open() rather than raw open(), so that your command
automatically supports /dev/fdset/nnn notation for reusing a file
descriptor passed in via SCM_RIGHTS.
> +++ b/qapi-schema.json
> @@ -3648,3 +3648,14 @@
> # Since: 2.1
> ##
> { 'command': 'rtc-reset-reinjection' }
> +
> +##
> +# @dump-pc-ram:
> +#
> +# Checkpoints guest.
The whole guest, or just guest memory?
> +#
> +# @file: the file to save the memory to as binary data
> +#
> +# Returns: Nothing on success
Missing a 'Since: 2.4' designation.
> +##
> +{ 'command': 'dump-pc-ram', 'data': {'file': 'str'} }
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH RFC 0/3] Checkpoint-assisted migration proposal, Bohdan Trach, 2015/04/17
- [Qemu-devel] [PATCH RFC 1/3] memory: Add dump-pc-mem command for checkpointing, Bohdan Trach, 2015/04/17
- Re: [Qemu-devel] [PATCH RFC 1/3] memory: Add dump-pc-mem command for checkpointing,
Eric Blake <=
- [Qemu-devel] [PATCH RFC 2/3] memory: implement checkpoint handling, Bohdan Trach, 2015/04/17
- [Qemu-devel] [PATCH RFC 3/3] migration: use checkpoint during migration, Bohdan Trach, 2015/04/17
- Re: [Qemu-devel] [PATCH RFC, Ping 0/3] Checkpoint-assisted migration proposal, Bohdan Trach, 2015/04/24