[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v1 RFC 23/34] io: add QIOChannelSocket class
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH v1 RFC 23/34] io: add QIOChannelSocket class |
Date: |
Fri, 17 Apr 2015 18:00:33 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 |
On 17/04/2015 17:52, Daniel P. Berrange wrote:
>>> > > +QIOChannelSocket *
>>> > > +qio_channel_socket_accept(QIOChannelSocket *ioc,
>>> > > + Error **errp);
>> >
>> > Does it make sense for a passive socket to be a QIOChannelSocket? We
>> > have already a pretty decent API in util/qemu-sockets.c, and
>> > QIOChannelSocket will become more similar to qemu-sockets if you switch
>> > to SocketAddress. Perhaps this function can just take a file descriptor?
> I was somewhat undecided about that really - One of my todos is to see
> about better integrating with qemu-sockets for the connection facilities,
> so will consider this problem too.
Hmm, I guess it makes sense to have the passive socket as a QOM object,
so it is okay.
Paolo
- [Qemu-devel] [PATCH v1 RFC 18/34] ui: convert VNC websockets to use crypto APIs, (continued)
- [Qemu-devel] [PATCH v1 RFC 18/34] ui: convert VNC websockets to use crypto APIs, Daniel P. Berrange, 2015/04/17
- [Qemu-devel] [PATCH v1 RFC 15/34] crypto: add sanity checking of TLS credentials, Daniel P. Berrange, 2015/04/17
- [Qemu-devel] [PATCH v1 RFC 19/34] block: convert qcow/qcow2 to use generic cipher API, Daniel P. Berrange, 2015/04/17
- [Qemu-devel] [PATCH v1 RFC 21/34] io: add abstract QIOChannel classes, Daniel P. Berrange, 2015/04/17
- [Qemu-devel] [PATCH v1 RFC 20/34] ui: convert VNC to use generic cipher API, Daniel P. Berrange, 2015/04/17
- [Qemu-devel] [PATCH v1 RFC 22/34] io: add helper module for creating watches on UNIX FDs, Daniel P. Berrange, 2015/04/17
- [Qemu-devel] [PATCH v1 RFC 24/34] io: add QIOChannelFile class, Daniel P. Berrange, 2015/04/17
- [Qemu-devel] [PATCH v1 RFC 23/34] io: add QIOChannelSocket class, Daniel P. Berrange, 2015/04/17
- Re: [Qemu-devel] [PATCH v1 RFC 23/34] io: add QIOChannelSocket class, Gerd Hoffmann, 2015/04/20
- [Qemu-devel] [PATCH v1 RFC 25/34] io: add QIOTask class for async operations, Daniel P. Berrange, 2015/04/17
- Re: [Qemu-devel] [PATCH v1 RFC 25/34] io: add QIOTask class for async operations, Paolo Bonzini, 2015/04/17
- Re: [Qemu-devel] [PATCH v1 RFC 25/34] io: add QIOTask class for async operations, Daniel P. Berrange, 2015/04/17
- Re: [Qemu-devel] [PATCH v1 RFC 25/34] io: add QIOTask class for async operations, Paolo Bonzini, 2015/04/17
- Re: [Qemu-devel] [PATCH v1 RFC 25/34] io: add QIOTask class for async operations, Daniel P. Berrange, 2015/04/17
- Re: [Qemu-devel] [PATCH v1 RFC 25/34] io: add QIOTask class for async operations, Paolo Bonzini, 2015/04/17
- Re: [Qemu-devel] [PATCH v1 RFC 25/34] io: add QIOTask class for async operations, Daniel P. Berrange, 2015/04/17
[Qemu-devel] [PATCH v1 RFC 26/34] io: add QIOChannelTLS class, Daniel P. Berrange, 2015/04/17