qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] target-arm: rename c1_coproc to cpacr_el1


From: Peter Maydell
Subject: Re: [Qemu-devel] [PATCH] target-arm: rename c1_coproc to cpacr_el1
Date: Tue, 21 Apr 2015 14:49:38 +0100

On 17 March 2015 at 16:23, Peter Maydell <address@hidden> wrote:
> On 17 March 2015 at 15:33, Sergey Fedorov <address@hidden> wrote:
>> Rename the field holding CPACR_EL1 system register state in AArch64
>> naming style.
>>
>> Signed-off-by: Sergey Fedorov <address@hidden>
>
> Reviewed-by: Peter Maydell <address@hidden>
>
> Mostly I've been renaming these only where we needed to
> touch them for some other reason, but this one is particularly
> confusing as a name, I think, and it doesn't touch too many
> lines to change it.
>
> Not for 2.3, though.

I'm adding this to target-arm.next for 2.4 now, and I
just noticed that you missed the occurrences in cpu.c.
If you'd built the linux-user emulators you'd have found
this because they wouldn't have built :-)

I'll fix this up as I apply the patch.

thanks
-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]