qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v3 0/27] write/create for Parallels images with


From: Stefan Hajnoczi
Subject: Re: [Qemu-devel] [PATCH v3 0/27] write/create for Parallels images with reasonable performance
Date: Wed, 22 Apr 2015 15:19:14 +0100
User-agent: Mutt/1.5.23 (2014-03-12)

On Wed, Mar 11, 2015 at 01:27:54PM +0300, Denis V. Lunev wrote:
> This patchset provides an ability to create of/write to Parallels
> images and some testing of the new code. Readings and writings are
> optimized out and I expect the same or slightly better performance
> as qcow2.
> 
> This patchset consists of not problematic part of the previous
> patchset aka
>    [PATCH v4 0/16] parallels format support improvements
> and new write/create code but it does not contradict questionable code
> with XML handling there.
> 
> Changes from v3:
> - fixed checkpatch warnings even in just moved code. I am tired of them :)
> - fixed contingency check in patch 18
> 
> Changes from v2:
> - read performance is almost doubled (up to 360 Mb/sec), write performance
>   is improved by 15-20%
> - bat caching approach changed completely. bat_bitmap now contains the data
>   in on-disk format, which allows to use this data for metadata cache
> - incorrect close detection code is added (inuse field in the header)
> - very basic check consistency code added
> 
> Changes from v1:
> - patches 13-19 added, which boosts performance from 800 KiB/sec to
>   near native performance
> 
> Signed-off-by: Denis V. Lunev <address@hidden>
> CC: Roman Kagan <address@hidden>
> CC: Jeff Cody <address@hidden>
> CC: Kevin Wolf <address@hidden>
> CC: Stefan Hajnoczi <address@hidden>

I have done a first pass review and left comments.  Thanks!

Attachment: pgpsemf7J0PFy.pgp
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]