qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v3 1/2] hw/net/virtio-net: Move DEFINE_VIRTIO_NE


From: Cornelia Huck
Subject: Re: [Qemu-devel] [PATCH v3 1/2] hw/net/virtio-net: Move DEFINE_VIRTIO_NET_FEATURES to virtio-net
Date: Wed, 22 Apr 2015 16:24:10 +0200

On Tue, 21 Apr 2015 18:51:10 +0800
address@hidden wrote:

I'd drop the leading "hw/net/" from the subject.

> From: Shannon Zhao <address@hidden>
> 
> Move DEFINE_VIRTIO_NET_FEATURES to the backend virtio-net.
> The transports just sync the host features from backend.
> Meanwhile move virtio_net_set_config_size to virtio-net.

Could you elaborate on why this makes sense?

> 
> Signed-off-by: Shannon Zhao <address@hidden>
> Signed-off-by: Shannon Zhao <address@hidden>
> ---
>  hw/net/virtio-net.c            | 5 +++++
>  hw/s390x/s390-virtio-bus.c     | 2 --
>  hw/s390x/virtio-ccw.c          | 2 --
>  hw/virtio/virtio-pci.c         | 2 --
>  include/hw/virtio/virtio-net.h | 1 +
>  5 files changed, 6 insertions(+), 6 deletions(-)

FWIW, this survives basic sanity checks on virtio-ccw - also in
combination with my realization sequence reordering patches I sent
yesterday.

Haven't gotten around to s390-virtio or virtio-scsi yet.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]