Re: [Qemu-devel] [PATCH 4/5] scripts: qmp-shell: add transaction subshell

[Eric Blake]

On 04/22/2015 09:02 AM, John Snow wrote:

> Yeah, not a big deal. The function that invokes this one actually
> explicitly checks for an empty string and avoids __build_cmd already.
> 
> If it gets spaces, It actually currently errors out with "list index out
> of range" which is not helpful or interesting.
> 
> This will at least improve it to do "nothing."

> 
> The behavior of just ignoring empty and blank lines is suitable
> regardless of mode, I think, unless you have a counter argument.

No counter argument here; but it does mean that we should improve the
commit message, to mention that it is an intentionally nice side effect
of the change :)

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature