[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 1/2] hw/net/virtio-net: Move DEFINE_VIRTIO_NE
From: |
Shannon Zhao |
Subject: |
Re: [Qemu-devel] [PATCH v3 1/2] hw/net/virtio-net: Move DEFINE_VIRTIO_NET_FEATURES to virtio-net |
Date: |
Thu, 23 Apr 2015 08:31:26 +0800 |
User-agent: |
Mozilla/5.0 (Windows NT 6.1; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 |
On 2015/4/22 22:24, Cornelia Huck wrote:
> On Tue, 21 Apr 2015 18:51:10 +0800
> address@hidden wrote:
>
> I'd drop the leading "hw/net/" from the subject.
>
Ok, thanks.
>> From: Shannon Zhao <address@hidden>
>>
>> Move DEFINE_VIRTIO_NET_FEATURES to the backend virtio-net.
>> The transports just sync the host features from backend.
>> Meanwhile move virtio_net_set_config_size to virtio-net.
>
> Could you elaborate on why this makes sense?
>
Ok, will add.
>>
>> Signed-off-by: Shannon Zhao <address@hidden>
>> Signed-off-by: Shannon Zhao <address@hidden>
>> ---
>> hw/net/virtio-net.c | 5 +++++
>> hw/s390x/s390-virtio-bus.c | 2 --
>> hw/s390x/virtio-ccw.c | 2 --
>> hw/virtio/virtio-pci.c | 2 --
>> include/hw/virtio/virtio-net.h | 1 +
>> 5 files changed, 6 insertions(+), 6 deletions(-)
>
> FWIW, this survives basic sanity checks on virtio-ccw - also in
> combination with my realization sequence reordering patches I sent
> yesterday.
>
> Haven't gotten around to s390-virtio or virtio-scsi yet.
>
--
Shannon
- [Qemu-devel] [PATCH v3 0/2] virtio: Move host features to backends, shannon . zhao, 2015/04/21
- [Qemu-devel] [PATCH v3 1/2] hw/net/virtio-net: Move DEFINE_VIRTIO_NET_FEATURES to virtio-net, shannon . zhao, 2015/04/21
- [Qemu-devel] [PATCH v3 2/2] virtio-scsi: Move DEFINE_VIRTIO_SCSI_FEATURES to virtio-scsi, shannon . zhao, 2015/04/21
- Re: [Qemu-devel] [PATCH v3 2/2] virtio-scsi: Move DEFINE_VIRTIO_SCSI_FEATURES to virtio-scsi, Shannon Zhao, 2015/04/27
- Re: [Qemu-devel] [PATCH v3 2/2] virtio-scsi: Move DEFINE_VIRTIO_SCSI_FEATURES to virtio-scsi, Michael S. Tsirkin, 2015/04/28
- Re: [Qemu-devel] [PATCH v3 2/2] virtio-scsi: Move DEFINE_VIRTIO_SCSI_FEATURES to virtio-scsi, Shannon Zhao, 2015/04/28
- Re: [Qemu-devel] [PATCH v3 2/2] virtio-scsi: Move DEFINE_VIRTIO_SCSI_FEATURES to virtio-scsi, Michael S. Tsirkin, 2015/04/28
- Re: [Qemu-devel] [PATCH v3 2/2] virtio-scsi: Move DEFINE_VIRTIO_SCSI_FEATURES to virtio-scsi, Shannon Zhao, 2015/04/28
- Re: [Qemu-devel] [PATCH v3 2/2] virtio-scsi: Move DEFINE_VIRTIO_SCSI_FEATURES to virtio-scsi, Michael S. Tsirkin, 2015/04/28
- Re: [Qemu-devel] [PATCH v3 2/2] virtio-scsi: Move DEFINE_VIRTIO_SCSI_FEATURES to virtio-scsi, Peter Maydell, 2015/04/28