[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH target-arm v4 11/16] char: cadence_uart: Split s
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH target-arm v4 11/16] char: cadence_uart: Split state struct and type into header |
Date: |
Thu, 23 Apr 2015 19:00:40 +0100 |
On 23 March 2015 at 11:05, Peter Crosthwaite
<address@hidden> wrote:
> To allow using the device with modern SoC programming conventions. The
> state struct needs to be visible to embed the device in SoC containers.
>
> Reviewed-by: Alistair Francis <address@hidden>
> Signed-off-by: Peter Crosthwaite <address@hidden>
Non-standalone commit message body, header file needs copyright/license
comment, include guard shouldn't have trailing _. Otherwise:
Reviewed-by: Peter Maydell <address@hidden>
thanks
-- PMM
- Re: [Qemu-devel] [PATCH target-arm v4 11/16] char: cadence_uart: Split state struct and type into header,
Peter Maydell <=