qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH target-arm v4 15/16] arm: xilinx-ep108: Add boot


From: Peter Crosthwaite
Subject: Re: [Qemu-devel] [PATCH target-arm v4 15/16] arm: xilinx-ep108: Add bootloading
Date: Thu, 23 Apr 2015 17:43:07 -0700

On Thu, Apr 23, 2015 at 11:15 AM, Peter Maydell
<address@hidden> wrote:
> On 23 March 2015 at 11:05, Peter Crosthwaite
> <address@hidden> wrote:
>> Using standard ARM bootloader.
>
> Commit msg, etc.
>
>> Signed-off-by: Peter Crosthwaite <address@hidden>
>> ---
>>  hw/arm/xlnx-ep108.c | 8 ++++++++
>>  1 file changed, 8 insertions(+)
>>
>> diff --git a/hw/arm/xlnx-ep108.c b/hw/arm/xlnx-ep108.c
>> index 6e89456..a86f595 100644
>> --- a/hw/arm/xlnx-ep108.c
>> +++ b/hw/arm/xlnx-ep108.c
>> @@ -28,6 +28,8 @@ typedef struct XlnxEP108 {
>>  /* Max 2GB RAM */
>>  #define EP108_MAX_RAM_SIZE 0x80000000ull
>>
>> +static struct arm_boot_info xlnx_ep108_binfo;
>> +
>>  static void xlnx_ep108_init(MachineState *machine)
>>  {
>>      XlnxEP108 *s = g_new0(XlnxEP108, 1);
>> @@ -58,6 +60,12 @@ static void xlnx_ep108_init(MachineState *machine)
>>                             &error_abort);
>>      vmstate_register_ram_global(&s->ddr_ram);
>>      memory_region_add_subregion(get_system_memory(), 0, &s->ddr_ram);
>> +
>> +    xlnx_ep108_binfo.ram_size = machine->ram_size;
>> +    xlnx_ep108_binfo.kernel_filename = machine->kernel_filename;
>> +    xlnx_ep108_binfo.kernel_cmdline = machine->kernel_cmdline;
>> +    xlnx_ep108_binfo.initrd_filename = machine->initrd_filename;
>
> nb_cpus, loader_start ?
>

I don't see any valid use for non-0 nb_cpus for aarch64 bootloading. I
think PSCI just handles it all? default_write_secondary will write in
smpboot contents which is AA32.

Loader start is 0. I'll make it explicit.

Regards,
Peter

>> +    arm_load_kernel(&s->soc.cpu[0], &xlnx_ep108_binfo);
>>  }
>>
>>  static QEMUMachine xlnx_ep108_machine = {
>> --
>> 2.3.1.2.g90df61e.dirty
>
> thanks
> -- PMM
>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]