qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] i440fx-test: remove ARRAY_SIZE redefinition


From: Peter Crosthwaite
Subject: Re: [Qemu-devel] [PATCH] i440fx-test: remove ARRAY_SIZE redefinition
Date: Sun, 26 Apr 2015 19:18:41 -0700

On Sun, Apr 26, 2015 at 3:04 PM, Emilio G. Cota <address@hidden> wrote:
> It's defined in osdep.h and shouldn't be redefined here.
>
> Signed-off-by: Emilio G. Cota <address@hidden>


Reviewed-by: Peter Crosthwaite <address@hidden>

It looks like there may be another one too:

hw/audio/fmopl.c:#define ARRAY_SIZE(x) (sizeof(x) / sizeof((x)[0]))

Regards,
Peter


> ---
>  tests/i440fx-test.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/tests/i440fx-test.c b/tests/i440fx-test.c
> index d0bc8de..33a7ecb 100644
> --- a/tests/i440fx-test.c
> +++ b/tests/i440fx-test.c
> @@ -27,8 +27,6 @@
>
>  #define BROKEN 1
>
> -#define ARRAY_SIZE(array) (sizeof(array) / sizeof((array)[0]))
> -
>  typedef struct TestData
>  {
>      int num_cpus;
> --
> 1.9.1
>
>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]