[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V15 1/5] docs: vm generation id device's descrip
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH V15 1/5] docs: vm generation id device's description |
|
Date: |
Mon, 27 Apr 2015 08:56:43 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 |
On 04/27/2015 05:19 AM, Gal Hammer wrote:
> Signed-off-by: Gal Hammer <address@hidden>
> ---
> docs/specs/vmgenid.txt | 35 +++++++++++++++++++++++++++++++++++
> 1 file changed, 35 insertions(+)
> create mode 100644 docs/specs/vmgenid.txt
>
> diff --git a/docs/specs/vmgenid.txt b/docs/specs/vmgenid.txt
> new file mode 100644
> index 0000000..86ce6ab
> --- /dev/null
> +++ b/docs/specs/vmgenid.txt
> @@ -0,0 +1,35 @@
> +VIRTUAL MACHINE GENERATION ID
> +=============================
> +
> +Copyright (C) 2014 Red Hat, Inc.
Do you want to include 2015?
What you have is good. But it might also be worth documenting how one
would set a new value via QMP (I assume it is a matter of finding the
right QOM path to the device, then using 'qom-set' on the property).
Can be done as a separate patch on top, so:
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH V15 0/5] Virtual Machine Generation ID, Gal Hammer, 2015/04/27
- [Qemu-devel] [PATCH V15 1/5] docs: vm generation id device's description, Gal Hammer, 2015/04/27
- [Qemu-devel] [PATCH V15 2/5] acpi: add a vm_generation_id_changed method, Gal Hammer, 2015/04/27
- [Qemu-devel] [PATCH V15 3/5] aml: implement a 32-bit fixed memory range descriptor, Gal Hammer, 2015/04/27
- [Qemu-devel] [PATCH V15 4/5] i386: add a Virtual Machine Generation ID device, Gal Hammer, 2015/04/27
- [Qemu-devel] [PATCH V15 5/5] tests: add a unit test for the vmgenid device., Gal Hammer, 2015/04/27