[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] i440fx-test: remove ARRAY_SIZE redefinition
From: |
Emilio G. Cota |
Subject: |
Re: [Qemu-devel] [PATCH] i440fx-test: remove ARRAY_SIZE redefinition |
Date: |
Mon, 27 Apr 2015 11:39:46 -0400 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Sun, Apr 26, 2015 at 19:18:41 -0700, Peter Crosthwaite wrote:
> On Sun, Apr 26, 2015 at 3:04 PM, Emilio G. Cota <address@hidden> wrote:
> > It's defined in osdep.h and shouldn't be redefined here.
> >
> > Signed-off-by: Emilio G. Cota <address@hidden>
>
>
> Reviewed-by: Peter Crosthwaite <address@hidden>
Thanks for having a look!
> It looks like there may be another one too:
>
> hw/audio/fmopl.c:#define ARRAY_SIZE(x) (sizeof(x) / sizeof((x)[0]))
That one is protected by #ifndef ARRAY_SIZE and AFAICT the file does not
include any qemu headers, so we can safely leave it as is.
Emilio