qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v6 08/36] qapi: Add some union tests


From: Markus Armbruster
Subject: Re: [Qemu-devel] [PATCH v6 08/36] qapi: Add some union tests
Date: Mon, 27 Apr 2015 18:18:08 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux)

Eric Blake <address@hidden> writes:

> Demonstrate that the qapi generator doesn't deal well with unions
> that aren't up to par. Later patches will update the expected
> reseults as the generator is made stricter.  A few tests work
> as planned, but most show poor or missing error messages.
>
> Of particular note, qapi-code-gen.txt documents 'base' only for
> flat unions, but the tests here demonstrate that we currently allow
> a 'base' to a simple union, although it is exercised only in the
> testsuite.  Later patches will remove this undocumented feature, to
> give us more flexibility in adding other future extensions to union
> types.  For example, one possible extension is the idea of a
> type-safe simple enum, where added fields tie the discriminator to
> a user-defined enum type rather than creating an implicit enum from
> the names in 'data'.  But adding such safety on top of a simple
> enum with a base type could look ambiguous with a flat enum;
> besides, the documentation also mentions how any simple union can
> be represented by an equivalent flat union.  So it will be simpler
> to just outlaw support for something we aren't using.
>
> Signed-off-by: Eric Blake <address@hidden>

Reviewed-by: Markus Armbruster <address@hidden>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]