qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 3/3] target-arm: Add the GICv2m to the virt boar


From: Peter Maydell
Subject: Re: [Qemu-devel] [PATCH 3/3] target-arm: Add the GICv2m to the virt board
Date: Mon, 27 Apr 2015 17:18:40 +0100

On 27 April 2015 at 17:06, Christoffer Dall <address@hidden> wrote:
> On Tue, Apr 21, 2015 at 03:47:13PM +0100, Peter Maydell wrote:
>
> [...]
>
>> > @@ -340,9 +357,31 @@ static void fdt_add_gic_node(VirtBoardInfo *vbi)
>> >                                       2, vbi->memmap[VIRT_GIC_DIST].size,
>> >                                       2, vbi->memmap[VIRT_GIC_CPU].base,
>> >                                       2, vbi->memmap[VIRT_GIC_CPU].size);
>> > +    qemu_fdt_setprop_cell(vbi->fdt, "/intc", "#address-cells", 0x2);
>> > +    qemu_fdt_setprop_cell(vbi->fdt, "/intc", "#size-cells", 0x2);
>> > +    qemu_fdt_setprop(vbi->fdt, "/intc", "ranges", NULL, 0);
>> >
>>
>> Why do we need an empty ranges attribute?
>>
>
> Without it, Linux fails to make things work.  I suspect this is related
> to specifically setting the #address-cells and #size-cells.

Looking at the DT spec I think it's a requirement for any node
which has children, to specify the address translation.
Empty ranges means "1:1 translation" (and more complicated
transformations are possible).

-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]