[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-next] pc: Ensure non-zero CPU ref count afte
From: |
Eduardo Habkost |
Subject: |
Re: [Qemu-devel] [PATCH for-next] pc: Ensure non-zero CPU ref count after attaching to ICC bus |
Date: |
Mon, 27 Apr 2015 16:35:13 -0300 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Tue, Mar 17, 2015 at 05:46:36PM +0100, Andreas Färber wrote:
> Setting the parent bus of a device increases its ref count, which we
> ultimately want to level out. However it is only safe to do so after the
> last reference to the device in local code, as qom-set or similar operations
> might decrease the ref count.
>
> Therefore move the object_unref() from pc_new_cpu() into its callers.
>
> The APIC operations on the last CPU in pc_cpus_init() are still potentially
> insecure, but that is beyond the scope of this code movement.
>
> Signed-off-by: Andreas Färber <address@hidden>
Applied, thanks.
--
Eduardo