Re: [Qemu-devel] [PATCH V6 for-2.3 09/26] hw/pci: move pci bus related code to separate files

[Michael S. Tsirkin]

On Mon, Apr 27, 2015 at 03:26:44PM +0300, Marcel Apfelbaum wrote:
> On 04/27/2015 02:14 PM, Michael S. Tsirkin wrote:
> >On Thu, Mar 19, 2015 at 08:52:44PM +0200, Marcel Apfelbaum wrote:
> >>@@ -2414,7 +1945,6 @@ static const TypeInfo pci_device_type_info = {
> >>
> >>  static void pci_register_types(void)
> >>  {
> >>-    type_register_static(&pci_bus_info);
> >>      type_register_static(&pcie_bus_info);
> >>      type_register_static(&pci_device_type_info);
> >>  }
> >
> >So pcie bus is not moved.  This seems pretty inconsistent.
> There were a lot of code dependencies. I moved the minimum code in order
> to be able to add code specific to PCIBus.

Interfaces need to make sense, this one feels like you randomly moved out
parts that your patch happens to need.
Just keep it all in pci.c for now.

-- 
MST