Re: [Qemu-devel] [PATCH v6 16/36] qapi: Use 'alternate' to replace anonymous union

[Markus Armbruster]

Eric Blake <address@hidden> writes:

> Previous patches have led up to the point where I create the
> new meta-type "'alternate':'Foo'".  See the previous patches
> for documentation; I intentionally split as much work into
> earlier patches to minimize the size of this patch, but a lot
> of it is churn due to testsuite fallout after updating to the
> new type.
>
> Signed-off-by: Eric Blake <address@hidden>
[...]
> diff --git a/tests/qapi-schema/flat-union-base-union.json 
> b/tests/qapi-schema/flat-union-base-union.json
> index 838986c..0ba6e28 100644
> --- a/tests/qapi-schema/flat-union-base-union.json
> +++ b/tests/qapi-schema/flat-union-base-union.json
> @@ -1,4 +1,4 @@
> -# FIXME: the error message needs help: we require the base to be a struct
> +# we require the base to be a struct
>  { 'enum': 'TestEnum',
>    'data': [ 'value1', 'value2' ] }
>  { 'type': 'TestTypeA',

This looks unrelated.  Does it belong to PATCH 25?

[...]

Regardless,
Reviewed-by: Markus Armbruster <address@hidden>