qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH V15 1/5] docs: vm generation id device's descrip


From: Gal Hammer
Subject: Re: [Qemu-devel] [PATCH V15 1/5] docs: vm generation id device's description
Date: Tue, 28 Apr 2015 17:38:31 +0300
User-agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0

On 27/04/2015 17:56, Eric Blake wrote:
On 04/27/2015 05:19 AM, Gal Hammer wrote:
Signed-off-by: Gal Hammer <address@hidden>
---
  docs/specs/vmgenid.txt | 35 +++++++++++++++++++++++++++++++++++
  1 file changed, 35 insertions(+)
  create mode 100644 docs/specs/vmgenid.txt

diff --git a/docs/specs/vmgenid.txt b/docs/specs/vmgenid.txt
new file mode 100644
index 0000000..86ce6ab
--- /dev/null
+++ b/docs/specs/vmgenid.txt
@@ -0,0 +1,35 @@
+VIRTUAL MACHINE GENERATION ID
+=============================
+
+Copyright (C) 2014 Red Hat, Inc.

Do you want to include 2015?

Done.

What you have is good.  But it might also be worth documenting how one
would set a new value via QMP (I assume it is a matter of finding the
right QOM path to the device, then using 'qom-set' on the property).
Can be done as a separate patch on top, so:

Good idea. I'll add it.

Reviewed-by: Eric Blake <address@hidden>

Thanks! :-)

    Gal.






reply via email to

[Prev in Thread] Current Thread [Next in Thread]