[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6 32/36] qapi: Drop tests for inline nested str
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v6 32/36] qapi: Drop tests for inline nested structs |
Date: |
Tue, 28 Apr 2015 11:29:42 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 |
On 04/28/2015 07:00 AM, Markus Armbruster wrote:
> Eric Blake <address@hidden> writes:
>
>> A future patch will be using a 'name':{dictionary} entry in the
>> QAPI schema to specify a default value for an optional argument;
>> but existing use of inline nested structs conflicts with that goal.
>>
>> +++ b/tests/test-visitor-serialization.c
>> @@ -1,7 +1,7 @@
>> /*
>> * Unit-tests for visitor-based serialization
>> *
>> - * Copyright IBM, Corp. 2012
>> + * Copyright IBM, Corp. 2012, 2015
>
> More accurate would be:
>
> - * Copyright IBM, Corp. 2012,2013
> + * Copyright IBM, Corp. 2014, 2015
> + * Copyright (C) 2014, 2015 Red Hat Inc.
Bummer - serves me right for trusting emacs' ability to auto-add
copyright, without checking which line it added to.
>
>> *
>> * Authors:
>> * Michael Roth <address@hidden>
>
> R-by stands all the same.
I'm adding this fix to a series followup, if there is no other reason to
respin.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v6 29/36] qapi: Document 'struct' metatype, (continued)
- [Qemu-devel] [PATCH v6 29/36] qapi: Document 'struct' metatype, Eric Blake, 2015/04/05
- [Qemu-devel] [PATCH v6 31/36] qapi: Merge UserDefTwo and UserDefNested in tests, Eric Blake, 2015/04/05
- [Qemu-devel] [PATCH v6 34/36] qapi: Drop inline nested structs in query-pci, Eric Blake, 2015/04/05
- [Qemu-devel] [PATCH v6 33/36] qapi: Drop inline nested struct in query-version, Eric Blake, 2015/04/05
- [Qemu-devel] [PATCH v6 35/36] qapi: Drop support for inline nested types, Eric Blake, 2015/04/05
- [Qemu-devel] [PATCH v6 36/36] qapi: Tweak doc references to QMP when QGA is also meant, Eric Blake, 2015/04/05
- [Qemu-devel] [PATCH v6 32/36] qapi: Drop tests for inline nested structs, Eric Blake, 2015/04/05
- [Qemu-devel] [PATCH v6 30/36] qapi: Use 'struct' instead of 'type' in schema, Eric Blake, 2015/04/05
- Re: [Qemu-devel] [PATCH v6 00/36] drop qapi nested structs, Eric Blake, 2015/04/06
- [Qemu-devel] [PATCH v6 38/36] qapi: Check for member name conflicts with a base class, Eric Blake, 2015/04/10
- [Qemu-devel] [PATCH v6 37/36] qapi: Support (subset of) \u escapes in strings, Eric Blake, 2015/04/10
- Re: [Qemu-devel] [PATCH v6 00/36] drop qapi nested structs, Markus Armbruster, 2015/04/28