qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v6 32/36] qapi: Drop tests for inline nested str


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH v6 32/36] qapi: Drop tests for inline nested structs
Date: Tue, 28 Apr 2015 11:29:42 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0

On 04/28/2015 07:00 AM, Markus Armbruster wrote:
> Eric Blake <address@hidden> writes:
> 
>> A future patch will be using a 'name':{dictionary} entry in the
>> QAPI schema to specify a default value for an optional argument;
>> but existing use of inline nested structs conflicts with that goal.
>>

>> +++ b/tests/test-visitor-serialization.c
>> @@ -1,7 +1,7 @@
>>  /*
>>   * Unit-tests for visitor-based serialization
>>   *
>> - * Copyright IBM, Corp. 2012
>> + * Copyright IBM, Corp. 2012, 2015
> 
> More accurate would be:
> 
>   - * Copyright IBM, Corp. 2012,2013
>   + * Copyright IBM, Corp. 2014, 2015
>   + * Copyright (C) 2014, 2015 Red Hat Inc.

Bummer - serves me right for trusting emacs' ability to auto-add
copyright, without checking which line it added to.

> 
>>   *
>>   * Authors:
>>   *  Michael Roth <address@hidden>
> 
> R-by stands all the same.

I'm adding this fix to a series followup, if there is no other reason to
respin.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]