[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6 00/36] drop qapi nested structs
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v6 00/36] drop qapi nested structs |
Date: |
Tue, 28 Apr 2015 11:51:04 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 |
On 04/28/2015 08:02 AM, Markus Armbruster wrote:
>> v6 changes are noted in each patch; in particular, several new
>> patches were added (additional tests, split some patches, conversion
>> to 'struct' instead of 'type'). But most of the changes were in
>> direct response to review comments or rebase fallout, so I kept
>> in Reviewed-by markings where possible, to help focus review on
>> the remainder.
>
> Looks good to go to me, except for new PATCH 37, where I suggested a
> small change. Shouldn't hold up this series. If any other patch still
> lacks my R-by, let me know.
Easier as a followup? Respin just the one patch? Or bite the bullet and
rebase the entire series (fixing the other trivial items and adding R-b
along the way)?
>
>> I wrote another patch while working on this series, but it was
>> independent enough that I posted it separately (although I based
>> the documentation in this patch as if that, or Markus' alternative,
>> had been applied):
>> https://lists.gnu.org/archive/html/qemu-devel/2015-04/msg00373.html
>
> Both need a trivial respin to correct a pasto. Yours has a more
> elaborate commit message, and a test. Mine is less code, in part
> because it uses a single qnull object instead of allocating one for each
> use, and it has separate patches for the qobject and the json-parser
> change.
>
> We can pick one, of we can combine the best of both into a new
> mini-series. Preferences?
I'll tackle a new mini-series with the best of both (I like your idea of
reusing the same object across all uses, instead of creating a new one
each time, particularly since it resulted in a smaller patch)
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH v6 32/36] qapi: Drop tests for inline nested structs, (continued)
- [Qemu-devel] [PATCH v6 30/36] qapi: Use 'struct' instead of 'type' in schema, Eric Blake, 2015/04/05
- Re: [Qemu-devel] [PATCH v6 00/36] drop qapi nested structs, Eric Blake, 2015/04/06
- [Qemu-devel] [PATCH v6 38/36] qapi: Check for member name conflicts with a base class, Eric Blake, 2015/04/10
- [Qemu-devel] [PATCH v6 37/36] qapi: Support (subset of) \u escapes in strings, Eric Blake, 2015/04/10
- Re: [Qemu-devel] [PATCH v6 00/36] drop qapi nested structs, Markus Armbruster, 2015/04/28
- Re: [Qemu-devel] [PATCH v6 00/36] drop qapi nested structs,
Eric Blake <=