qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v6 07/36] qapi: Better error messages for bad en


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH v6 07/36] qapi: Better error messages for bad enums
Date: Tue, 28 Apr 2015 17:08:03 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0

On 04/04/2015 10:07 PM, Eric Blake wrote:
> The previous commit demonstrated that the generator had several
> flaws with less-than-perfect enums:

> +++ b/tests/qapi-schema/enum-max-member.json
> @@ -1,3 +1,3 @@
> -# FIXME: we should either reject user-supplied 'max', or munge the implicit
> -# max value we generate at the end of an array
> +# we reject user-supplied 'max' for clashing with implicit enum end
> +# TODO: should we instead munge the the implicit value to avoid the clash?

double "the" needs fixing

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]