[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH RFC 12/19] qapi: Turn generators' mandatory opti
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH RFC 12/19] qapi: Turn generators' mandatory option -i into an argument |
Date: |
Wed, 29 Apr 2015 09:11:10 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) |
Eric Blake <address@hidden> writes:
> On 04/02/2015 11:28 AM, Markus Armbruster wrote:
>> Mandatory option is silly, and the error handling is missing: the
>> programs crash when -i isn't supplied. Make it an argument, and check
>> it properly.
>>
>> Signed-off-by: Markus Armbruster <address@hidden>
>> ---
>> Makefile | 14 +++++++-------
>> scripts/qapi.py | 10 ++++------
>> tests/Makefile | 8 ++++----
>> 3 files changed, 15 insertions(+), 17 deletions(-)
>
> Needs corresponding changes to docs/qapi-code-gen.txt (several examples
> use --input-file=...).
Indeed.
>> @@ -935,8 +932,9 @@ def parse_command_line(extra_options = "",
>> extra_long_options = []):
>> do_c = True
>> do_h = True
>>
>> - if len(args) != 0:
>> + if len(args) != 1:
>> print >>sys.stderr, "%s: too many arguments"% sys.argv[0]
>> sys.exit(1)
>
> Won't this report 'too many arguments' even for a missing argument?
Will fix. Thanks!
- [Qemu-devel] [PATCH RFC 00/19] qapi: QMP introspection, Markus Armbruster, 2015/04/02
- [Qemu-devel] [PATCH RFC 06/19] qapi: Use c_enum_const() in generate_alternate_qtypes(), Markus Armbruster, 2015/04/02
- [Qemu-devel] [PATCH RFC 07/19] qapi: Move camel_to_upper(), c_enum_const() to closely related code, Markus Armbruster, 2015/04/02
- [Qemu-devel] [PATCH RFC 12/19] qapi: Turn generators' mandatory option -i into an argument, Markus Armbruster, 2015/04/02
- [Qemu-devel] [PATCH RFC 09/19] qapi: qapi-commands.py option --type is unused, drop it, Markus Armbruster, 2015/04/02
- [Qemu-devel] [PATCH RFC 15/19] qapi: Inline gen_command_decl_prologue(), gen_command_def_prologue(), Markus Armbruster, 2015/04/02
- [Qemu-devel] [PATCH RFC 17/19] qobject: Add a special null QObject, Markus Armbruster, 2015/04/02
- [Qemu-devel] [PATCH RFC 14/19] qapi: Drop pointless flush() before close(), Markus Armbruster, 2015/04/02
- [Qemu-devel] [PATCH RFC 18/19] json-parser: Fix to recognize null, Markus Armbruster, 2015/04/02