[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v13 10/12] qdev: check callback takes the proper
From: |
Eric Auger |
Subject: |
Re: [Qemu-devel] [PATCH v13 10/12] qdev: check callback takes the property child as third argument |
Date: |
Wed, 29 Apr 2015 10:37:04 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 |
On 04/29/2015 10:22 AM, Paolo Bonzini wrote:
>
>
> On 28/04/2015 18:51, Eric Auger wrote:
>> - prop->check(obj, name, new_target, &local_err);
>> + object_ref(new_target);
>> + *child = new_target;
>> +
>> + prop->check(obj, name, child, &local_err);
>> if (local_err) {
>> error_propagate(errp, local_err);
>> + *child = old_target;
>> + object_ref(new_target);
>
> This should be an unref.
oups yes.
Thanks! Do I keep this series or do I revert to sysbus irq connect irq
temporary patch as per Peter's last email?
Eric
>
> Paolo
>
>> return;
>> }
>>
>> - object_ref(new_target);
>> - *child = new_target;
>> object_unref(old_target);
- [Qemu-devel] [PATCH v13 02/12] hw/vfio/platform: vfio-platform skeleton, (continued)
- [Qemu-devel] [PATCH v13 02/12] hw/vfio/platform: vfio-platform skeleton, Eric Auger, 2015/04/28
- [Qemu-devel] [PATCH v13 04/12] hw/vfio/platform: calxeda xgmac device, Eric Auger, 2015/04/28
- [Qemu-devel] [PATCH v13 03/12] hw/vfio/platform: add irq assignment, Eric Auger, 2015/04/28
- [Qemu-devel] [PATCH v13 06/12] kvm: rename kvm_irqchip_[add, remove]_irqfd_notifier with gsi suffix, Eric Auger, 2015/04/28
- [Qemu-devel] [PATCH v13 05/12] hw/arm/sysbus-fdt: enable vfio-calxeda-xgmac dynamic instantiation, Eric Auger, 2015/04/28
- [Qemu-devel] [PATCH v13 07/12] kvm-all.c: add qemu_irq/gsi hash table and utility routines, Eric Auger, 2015/04/28
- [Qemu-devel] [PATCH v13 08/12] intc: arm_gic_kvm: set the qemu_irq/gsi mapping, Eric Auger, 2015/04/28
- [Qemu-devel] [PATCH v13 09/12] qdev: pass the check callback to qdev_init_gpio_out_named, Eric Auger, 2015/04/28
- [Qemu-devel] [PATCH v13 10/12] qdev: check callback takes the property child as third argument, Eric Auger, 2015/04/28
[Qemu-devel] [PATCH v13 11/12] sysbus: add irq_set_hook, Eric Auger, 2015/04/28
[Qemu-devel] [PATCH v13 12/12] hw/vfio/platform: add irqfd support, Eric Auger, 2015/04/28