qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v4 0/2] virtio: Move host features to backends


From: Cornelia Huck
Subject: Re: [Qemu-devel] [PATCH v4 0/2] virtio: Move host features to backends
Date: Wed, 29 Apr 2015 16:33:44 +0200

On Wed, 29 Apr 2015 12:32:04 +0200
"Michael S. Tsirkin" <address@hidden> wrote:

> On Wed, Apr 29, 2015 at 10:52:15AM +0200, Cornelia Huck wrote:

> > And (surprise, surprise) virtio-blk now works - but it also works when
> > I back out the atomic.h change again. No barrier problems :)
> > 
> > Good news is that we can change s390-virtio to be just like the other
> > transports. Although I'd like to understand why it was broken before.
> > Maybe a guest change?
> 
> Or a compiler change? Try compiling some old release, see what happens.

Nope, same compiler as back then (old setup). My current guess is some
change in other code.

> Anyway, let's move DEFINE_VIRTIO_COMMON_FEATURES into the base class
> now.  Can you send a patch pls?

I think virtio-blk-s390 not working anymore will be easy to catch (it
is used in some of the iotests). I'll move the features.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]