qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 0/7] virtio: inline private qdev properties into


From: Cornelia Huck
Subject: Re: [Qemu-devel] [PATCH 0/7] virtio: inline private qdev properties into virtio devices
Date: Thu, 30 Apr 2015 15:50:53 +0200

On Wed, 29 Apr 2015 23:24:02 +0800
Shannon Zhao <address@hidden> wrote:

> The private qdev properties of virtio devices are only used by
> themselves. As Peter suggested and like what virtio-blk has done, we
> should move the private qdev properties into devices and don't expose
> them to avoid wrongly use.
> 
> This patchset is based on following patchset which moves host features
> to backends.
> http://lists.gnu.org/archive/html/qemu-devel/2015-04/msg03785.html
> 
> Shannon Zhao (7):
>   virtio-net: move qdev properties into virtio-net.c
>   virtio-net.h: Remove unsed DEFINE_VIRTIO_NET_PROPERTIES
>   virtio-scsi: move qdev properties into virtio-scsi.c
>   virtio-rng: move qdev properties into virtio-rng.c
>   virtio-serial-bus: move qdev properties into virtio-serial-bus.c
>   virtio-9p-device: move qdev properties into virtio-9p-device.c
>   vhost-scsi: move qdev properties into vhost-scsi.c
> 
>  hw/9pfs/virtio-9p-device.c        |  3 ++-
>  hw/9pfs/virtio-9p.h               |  4 ----
>  hw/char/virtio-serial-bus.c       |  3 ++-
>  hw/net/virtio-net.c               | 42 
> ++++++++++++++++++++++++++++++++++++++-
>  hw/scsi/vhost-scsi.c              |  9 ++++++++-
>  hw/scsi/virtio-scsi.c             | 13 ++++++++++--
>  hw/virtio/virtio-rng.c            |  8 +++++++-
>  include/hw/virtio/vhost-scsi.h    |  9 ---------
>  include/hw/virtio/virtio-net.h    | 31 +----------------------------
>  include/hw/virtio/virtio-rng.h    | 10 ----------
>  include/hw/virtio/virtio-scsi.h   | 13 ------------
>  include/hw/virtio/virtio-serial.h |  3 ---
>  12 files changed, 72 insertions(+), 76 deletions(-)
> 

Other than my minor nit regarding indentation for virtio-net:

Acked-by: Cornelia Huck <address@hidden>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]