[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 4/7] qom: add object_new_propv / object_new_prop
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 4/7] qom: add object_new_propv / object_new_proplist constructors |
Date: |
Thu, 30 Apr 2015 17:00:28 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 |
On 30/04/2015 16:42, Daniel P. Berrange wrote:
> + propname = va_arg(vargs, char *);
> + while (propname != NULL) {
> + const char *value = va_arg(vargs, char *);
> +
> + g_assert(value != NULL);
> + object_property_parse(obj, value, propname, errp);
> + if (*errp) {
> + goto error;
> + }
> + propname = va_arg(vargs, char *);
> + }
> +
> + object_property_add_child(container_get(object_get_root(), path),
> + id, obj, errp);
> + if (*errp) {
> + goto error;
> + }
> +
> + if (object_dynamic_cast(obj, TYPE_USER_CREATABLE)) {
> + user_creatable_complete(obj, errp);
> + if (*errp) {
> + object_property_del(container_get(object_get_root(), path),
> + id, &error_abort);
Easier:
object_unparent(obj);
> + goto error;
> + }
> + }
> +
> + return obj;
And another one: do we want to unref the object here, since we've added
a stable reference via object_property_add_child?
Do you prefer me too apply patches 1-2-3-5-6-7, minus the testcases, or
do you simply want to resubmit?
Paolo
- [Qemu-devel] [PATCH 0/7] qom: misc fixes & enhancements to support TLS work, Daniel P. Berrange, 2015/04/30
- [Qemu-devel] [PATCH 2/7] qom: document user creatable object types in help text, Daniel P. Berrange, 2015/04/30
- [Qemu-devel] [PATCH 1/7] qom: fix typename of 'policy' enum property in hostmem obj, Daniel P. Berrange, 2015/04/30
- [Qemu-devel] [PATCH 5/7] qom: make enum string tables const-correct, Daniel P. Berrange, 2015/04/30
- [Qemu-devel] [PATCH 7/7] qom: don't pass string table to object_get_enum method, Daniel P. Berrange, 2015/04/30
- [Qemu-devel] [PATCH 4/7] qom: add object_new_propv / object_new_proplist constructors, Daniel P. Berrange, 2015/04/30
- [Qemu-devel] [PATCH 3/7] qom: create objects in two phases, Daniel P. Berrange, 2015/04/30
- [Qemu-devel] [PATCH 6/7] qom: add a object_property_add_enum helper method, Daniel P. Berrange, 2015/04/30