[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 7/7] Enable NVMe start controller for Windows guest.
From: |
Kevin Wolf |
Subject: |
[Qemu-devel] [PULL 7/7] Enable NVMe start controller for Windows guest. |
Date: |
Thu, 30 Apr 2015 21:10:16 +0200 |
From: Daniel Stekloff <address@hidden>
Windows seems to send two separate calls to NVMe controller configuration. The
first sends configuration info and the second the enable bit. I couldn't
enable the Windows 8.1 in-box NVMe driver with base Qemu. I made the
following change to store the configuration data and then handle enable and
NVMe driver works on Windows 8.1.
I am not a Windows expert and I'm not entirely sure this is the correct
approach. I'm offering it for anyone who wishes to use NVMe on Windows 8.1
using Qemu.
I have tested this change with Linux and Windows guests with NVMe devices.
Signed-off-by: Daniel Stekloff <address@hidden>
Acked-by: Keith Busch <address@hidden>
Signed-off-by: Kevin Wolf <address@hidden>
---
hw/block/nvme.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/hw/block/nvme.c b/hw/block/nvme.c
index 1e07166..ad988d7 100644
--- a/hw/block/nvme.c
+++ b/hw/block/nvme.c
@@ -615,6 +615,13 @@ static void nvme_write_bar(NvmeCtrl *n, hwaddr offset,
uint64_t data,
n->bar.intmc = n->bar.intms;
break;
case 0x14:
+ /* Windows first sends data, then sends enable bit */
+ if (!NVME_CC_EN(data) && !NVME_CC_EN(n->bar.cc) &&
+ !NVME_CC_SHN(data) && !NVME_CC_SHN(n->bar.cc))
+ {
+ n->bar.cc = data;
+ }
+
if (NVME_CC_EN(data) && !NVME_CC_EN(n->bar.cc)) {
n->bar.cc = data;
if (nvme_start_ctrl(n)) {
--
1.8.3.1
- [Qemu-devel] [PULL 0/7] Block patches, Kevin Wolf, 2015/04/30
- [Qemu-devel] [PULL 1/7] MAINTAINERS: make virtio-blk Stefan Hajnoczi's responsibility, Kevin Wolf, 2015/04/30
- [Qemu-devel] [PULL 3/7] MAINTAINERS: make block I/O path Stefan Hajnoczi's responsibility, Kevin Wolf, 2015/04/30
- [Qemu-devel] [PULL 2/7] MAINTAINERS: split out image formats, Kevin Wolf, 2015/04/30
- [Qemu-devel] [PULL 4/7] MAINTAINERS: make image fuzzer Stefan Hajnoczi's responsibility, Kevin Wolf, 2015/04/30
- [Qemu-devel] [PULL 5/7] MAINTAINERS: make block layer core Kevin Wolf's responsibility, Kevin Wolf, 2015/04/30
- [Qemu-devel] [PULL 6/7] MAINTAINERS: Add qemu-block list where missing, Kevin Wolf, 2015/04/30
- [Qemu-devel] [PULL 7/7] Enable NVMe start controller for Windows guest.,
Kevin Wolf <=