qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCHv7 22a/39] squash: qapi: Unify type bypass and add te


From: Eric Blake
Subject: [Qemu-devel] [PATCHv7 22a/39] squash: qapi: Unify type bypass and add tests
Date: Fri, 1 May 2015 14:10:34 -0600

Signed-off-by: Eric Blake <address@hidden>
---

This needs to be squashed into v7:22/39 to avoid a regression in QGA.
If you'd rather me post a single amended patch as v8, I can do that.

 scripts/qapi-commands.py | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)

diff --git a/scripts/qapi-commands.py b/scripts/qapi-commands.py
index 053ba85..cb78682 100644
--- a/scripts/qapi-commands.py
+++ b/scripts/qapi-commands.py
@@ -2,7 +2,7 @@
 # QAPI command marshaller generator
 #
 # Copyright IBM, Corp. 2011
-# Copyright (C) 2014 Red Hat, Inc.
+# Copyright (C) 2014-2015 Red Hat, Inc.
 #
 # Authors:
 #  Anthony Liguori <address@hidden>
@@ -293,17 +293,12 @@ out:

     return ret

-def option_value_matches(opt, val, cmd):
-    if opt in cmd and cmd[opt] == val:
-        return True
-    return False
-
 def gen_registry(commands):
     registry=""
     push_indent()
     for cmd in commands:
         options = 'QCO_NO_OPTIONS'
-        if option_value_matches('success-response', 'no', cmd):
+        if not cmd.get('success-response', True):
             options = 'QCO_NO_SUCCESS_RESP'

         registry += mcgen('''
-- 
2.1.0




reply via email to

[Prev in Thread] Current Thread [Next in Thread]