[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v8 22/40] qapi: Unify type bypass and add tests

From: Markus Armbruster
Subject: Re: [Qemu-devel] [PATCH v8 22/40] qapi: Unify type bypass and add tests
Date: Mon, 04 May 2015 19:42:59 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux)

Eric Blake <address@hidden> writes:

> For a few QMP commands, we are forced to pass an arbitrary type
> without tracking it properly in QAPI.  Among the existing clients,
> this unnamed type was spelled 'dict', 'visitor', and '**'; this
> patch standardizes on '**', matching the documentation changes
> earlier in the series.
> Meanwhile, for the 'gen' key, we have been ignoring the value,
> although the schema consistently used "'no'" ('success-response'
> was hard-coded to checking for 'no').  But now that we can support
> a literal "false" in the schema, we might as well use that rather
> than ignoring the value or special-casing a random string.  Note
> that these are one-way switches (use of 'gen':true is not the same
> as omitting 'gen'). Also, the use of '**' requires 'gen':false,
> but the use of 'gen':false does not mandate the use of '**'.
> There is no difference to the generated code.  Add some tests on
> what we'd like to guarantee, although it will take later patches
> to clean up test results and actually enforce the use of a bool
> parameter.
> Signed-off-by: Eric Blake <address@hidden>

Reviewed-by: Markus Armbruster <address@hidden>

reply via email to

[Prev in Thread] Current Thread [Next in Thread]