[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v8 00/40] drop qapi nested structs

From: Markus Armbruster
Subject: Re: [Qemu-devel] [PATCH v8 00/40] drop qapi nested structs
Date: Mon, 04 May 2015 20:19:46 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux)

Eric Blake <address@hidden> writes:

> We want to eventually allow qapi defaults, by making:
>  'data':{'*flag':'bool'}
>  as shorthand for something like:
>   'data':{'flag':{'type':'bool', 'optional':true}}
>   so that the default can be specified:
>    'data':{'flag':{'type':'bool', 'optional':true, 'default':true}}
> This series does not quite get us there, but it DOES do a number
> of other things.  It gets rid of the three uses of nested inline
> structs, changes anonymous unions to use a specific 'alternate'
> metatype rather than abusing 'union', changes the ambiguous 'type'
> to the obvious 'struct', and fixes lots of other parser bugs found
> while designing the testsuite.  The testsuite changes make the
> bulk of this series, with a repeating pattern of writing tests
> that expose weaknesses in the old parser, then beefing up the
> generator to catch the problem during the initial parse rather
> than choking with an obscure python message or even causing a C
> compilation failure.

Looks done to me.  I'll take it through my tree, as discussed in review
of v6.  I can fix up the nits I picked in PATCH 40.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]