[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PULL 00/40] drop qapi nested structs

From: Peter Maydell
Subject: Re: [Qemu-devel] [PULL 00/40] drop qapi nested structs
Date: Wed, 6 May 2015 11:16:09 +0100

On 5 May 2015 at 17:46, Markus Armbruster <address@hidden> wrote:
> We want to eventually allow qapi defaults, by making:
>  'data':{'*flag':'bool'}
>  as shorthand for something like:
>   'data':{'flag':{'type':'bool', 'optional':true}}
>   so that the default can be specified:
>    'data':{'flag':{'type':'bool', 'optional':true, 'default':true}}
> This series does not quite get us there, but it DOES do a number
> of other things.  It gets rid of the three uses of nested inline
> structs, changes anonymous unions to use a specific 'alternate'
> metatype rather than abusing 'union', changes the ambiguous 'type'
> to the obvious 'struct', and fixes lots of other parser bugs found
> while designing the testsuite.  The testsuite changes make the
> bulk of this series, with a repeating pattern of writing tests
> that expose weaknesses in the old parser, then beefing up the
> generator to catch the problem during the initial parse rather
> than choking with an obscure python message or even causing a C
> compilation failure.
> The following changes since commit 874e9aeeeb74c5459639a93439a502d262847e68:
>   Merge remote-tracking branch 'remotes/kraxel/tags/pull-sdl-20150505-1' into 
> staging (2015-05-05 14:06:12 +0100)
> are available in the git repository at:
>   git://repo.or.cz/qemu/armbru.git tags/pull-qmp-2015-05-05
> for you to fetch changes up to ff55d72eaf9628e7d58e7b067b361cdbf789c9f4:
>   qapi: Check for member name conflicts with a base class (2015-05-05 
> 18:39:02 +0200)
> ----------------------------------------------------------------
> drop qapi nested structs

Applied, thanks.

-- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]