[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 0/4] semihosting: clean up and add --semihosting

From: Leon Alrae
Subject: Re: [Qemu-devel] [PATCH 0/4] semihosting: clean up and add --semihosting-config arg
Date: Wed, 6 May 2015 17:12:30 +0100
User-agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0

On 06/05/2015 16:22, Liviu Ionescu wrote:
> apparently your patch does not fix the arm semihosting problems. do you plan 
> a separate patch for this?

This patchset doesn't contain any target semihosting specific changes
(just a clean up and new arg option). I'm going to follow up with UHI
patch series only. I don't have anything set up to test other
semihosting interfaces, thus I don't plan to do any changes in these
areas in near future. Therefore feel free to send your ARM semihosting

>> bool semihosting_enabled(void)
>> {
>>     return semihosting.allowed;
>> }
> any particular reason for naming the structure member ".allowed" and the 
> getter function "_enabled()"?

Generally no, but patch #1 introduced semihosting_enabled() function,
hence this change. However, thanks for pointing this out as I just
realized that with the patch #3 this rename was not required at all.
I'll correct that.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]