[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 1/7] qom: fix typename of 'policy' enum prope
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH v3 1/7] qom: fix typename of 'policy' enum property in hostmem obj |
Date: |
Fri, 08 May 2015 16:28:05 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 |
Am 01.05.2015 um 12:30 schrieb Daniel P. Berrange:
> The 'policy' property was being registered with a typename of
> 'str', but it is in fact an enum of the 'HostMemPolicy' type.
>
> Signed-off-by: Daniel P. Berrange <address@hidden>
> ---
> backends/hostmem.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/backends/hostmem.c b/backends/hostmem.c
> index b7b6cf8..f6db33c 100644
> --- a/backends/hostmem.c
> +++ b/backends/hostmem.c
> @@ -252,7 +252,7 @@ static void host_memory_backend_init(Object *obj)
> object_property_add(obj, "host-nodes", "int",
> host_memory_backend_get_host_nodes,
> host_memory_backend_set_host_nodes, NULL, NULL,
> NULL);
> - object_property_add(obj, "policy", "str",
> + object_property_add(obj, "policy", "HostMemPolicy",
> host_memory_backend_get_policy,
> host_memory_backend_set_policy, NULL, NULL, NULL);
> }
This patch is mislabeled IMO and none of my business, but cleanup is
appreciated,
Acked-by: Andreas Färber <address@hidden>
Regards,
Andreas
--
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu,
Graham Norton; HRB 21284 (AG Nürnberg)