|
From: | Richard Henderson |
Subject: | Re: [Qemu-devel] [PATCH v2 3/7] disas: arm-a64: Make printfer and stream variable |
Date: | Mon, 11 May 2015 08:57:33 -0700 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 |
On 05/09/2015 01:11 PM, Peter Crosthwaite wrote: > class QEMUDisassembler : public Disassembler { > public: > - explicit QEMUDisassembler(FILE *stream) : stream_(stream) { } > + QEMUDisassembler() { > + printf_ = NULL; > + stream_ = NULL; > + } As a nit, I would have written this QEMUDisassembler(FILE *stream) : stream_(NULL), printf_(NULL) { } but the difference is unlikely to matter here. Reviewed-by: Richard Henderson <address@hidden> r~
[Prev in Thread] | Current Thread | [Next in Thread] |